From: Chris Lamb Date: Tue, 27 Oct 2009 19:36:51 +0000 (+0000) Subject: Use set() instead of Perlesque hash[key] = 1 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=42c43f76d1aa14caeb842e3aabdbb8c4ed04b33a;p=dak Use set() instead of Perlesque hash[key] = 1 Signed-off-by: Chris Lamb --- diff --git a/daklib/queue.py b/daklib/queue.py index 3e2e6ef5..c2377294 100755 --- a/daklib/queue.py +++ b/daklib/queue.py @@ -1225,14 +1225,14 @@ class Upload(object): # through lintians output later to see if its a fatal tag we detected, or not. # So we only run lintian once on all tags, even if we might reject on some, but not # reject on others. - # Additionally built up a hash of tags - tags = {} + # Additionally build up a set of tags + tags = set() (fd, temp_filename) = utils.temp_filename() temptagfile = os.fdopen(fd, 'w') for tagtype in lintiantags: for tag in lintiantags[tagtype]: temptagfile.write(tag) - tags[tag]=1 + tags.add(tag) temptagfile.close() # So now we should look at running lintian at the .changes file, capturing output @@ -1259,7 +1259,7 @@ class Upload(object): etext = m.group(4) # So lets check if we know the tag at all. - if tags.has_key(etag): + if etag in tags: if etype == 'O': # We know it and it is overriden. Check that override is allowed. if lintiantags['warning'][etag]: