From: Lennart Poettering <lennart@poettering.net>
Date: Thu, 26 Aug 2010 02:08:28 +0000 (+0200)
Subject: service: if we cannot add an alias to a sysv service, ignore this and go on
X-Git-Tag: v9~38
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=42a097a2537878d90b00df88d36a8eeb6db5cef6;p=systemd

service: if we cannot add an alias to a sysv service, ignore this and go on
---

diff --git a/src/service.c b/src/service.c
index d2ef1ad9..1525aaea 100644
--- a/src/service.c
+++ b/src/service.c
@@ -571,10 +571,10 @@ static int service_load_sysv_path(Service *s, const char *path) {
                                         else
                                                 r = unit_add_dependency_by_name_inverse(u, UNIT_AFTER, m, NULL, true);
 
-                                        free(m);
-
                                         if (r < 0)
-                                                goto finish;
+                                                log_error("[%s:%u] Failed to add LSB Provides name %s: %s. Ignoring.", path, line, m, strerror(-r));
+
+                                        free(m);
                                 }
 
                         } else if (startswith_no_case(t, "Required-Start:") ||
@@ -604,10 +604,11 @@ static int service_load_sysv_path(Service *s, const char *path) {
                                                 continue;
 
                                         r = unit_add_dependency_by_name(u, startswith_no_case(t, "X-Start-Before:") ? UNIT_BEFORE : UNIT_AFTER, m, NULL, true);
-                                        free(m);
 
                                         if (r < 0)
-                                                goto finish;
+                                                log_error("Failed to add dependency on %s, ignoring: %s", m, strerror(-r));
+
+                                        free(m);
                                 }
                         } else if (startswith_no_case(t, "Default-Start:")) {
                                 char *k, *d;