From: Venkatesh Pallipadi Date: Tue, 14 Nov 2006 01:47:44 +0000 (-0800) Subject: [CPUFREQ] Fix the bug in duplicate freq elimination code in acpi-cpufreq X-Git-Tag: v2.6.20-rc1~151 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=3d4a7ef3d3f0c9f3cf8da724d5935253a713d8b6;p=linux-2.6 [CPUFREQ] Fix the bug in duplicate freq elimination code in acpi-cpufreq Fix the bug in duplicate states elimination in acpi-cpufreq. Bug: Due to duplicate state elimiation in the loop earlier, the number of valid_states can be less than perf->state_count, in which case freq_table was ending up with some garbage/uninitialized entries in the table. Signed-off-by: Venkatesh Pallipadi From: Alexey Starikovskiy Signed-off-by: Dave Jones --- diff --git a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c index 60d20cf427..18f4715c65 100644 --- a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c +++ b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c @@ -693,7 +693,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy) perf->states[i].core_frequency * 1000; valid_states++; } - data->freq_table[perf->state_count].frequency = CPUFREQ_TABLE_END; + data->freq_table[valid_states].frequency = CPUFREQ_TABLE_END; result = cpufreq_frequency_table_cpuinfo(policy, data->freq_table); if (result)