From: phk <phk@d4fa192b-c00b-0410-8231-f00ffab90ce4>
Date: Fri, 21 Sep 2007 09:49:44 +0000 (+0000)
Subject: Don't leak 50 bytes when creating the new Date: header.
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=33fd4e61954054b49ba9cf210c46fa0344c20697;p=varnish

Don't leak 50 bytes when creating the new Date: header.


git-svn-id: svn+ssh://projects.linpro.no/svn/varnish/trunk@1977 d4fa192b-c00b-0410-8231-f00ffab90ce4
---

diff --git a/varnish-cache/bin/varnishd/cache_response.c b/varnish-cache/bin/varnishd/cache_response.c
index 3cfdaef5..0fee9764 100644
--- a/varnish-cache/bin/varnishd/cache_response.c
+++ b/varnish-cache/bin/varnishd/cache_response.c
@@ -111,7 +111,7 @@ res_do_conds(struct sess *sp)
 void
 RES_BuildHttp(struct sess *sp)
 {
-	char *time_str;
+	char time_str[30];
 
 	CHECK_OBJ_NOTNULL(sp, SESS_MAGIC);
 
@@ -126,16 +126,8 @@ RES_BuildHttp(struct sess *sp)
 	http_FilterFields(sp->wrk, sp->fd, sp->http, &sp->obj->http,
 	    HTTPH_A_DELIVER);
 	
-	/* Replace Date header with current date instead of keeping the date
-	 * originally given by the backend when the object was fetched (which
-	 * could be a long time ago).
-	 */
-	http_Unset(sp->http, H_Date);
-	time_str = malloc(50);
-	XXXAN(time_str);
-	sprintf(time_str, "Date: ");
-	TIM_format(TIM_real(), &(time_str[6]));
-	http_SetHeader(sp->wrk, sp->fd, sp->http, time_str);
+	TIM_format(TIM_real(), time_str);
+	http_PrintfHeader(sp->wrk, sp->fd, sp->http, "Date: %s", time_str);
 	
 	if (sp->xid != sp->obj->xid)
 		http_PrintfHeader(sp->wrk, sp->fd, sp->http,