From: Krzysztof Halasa Date: Mon, 19 Sep 2005 22:39:32 +0000 (-0700) Subject: [WAN] hdlc_cisco: Fix regression introduced by skb->tail changes. X-Git-Tag: v2.6.14-rc2~2^2~2 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=2cf655cd65888e9fed0803d77e9e4f7d1db674cc;p=linux-2.6 [WAN] hdlc_cisco: Fix regression introduced by skb->tail changes. The following commit breaks cisco mode with my WAN drivers: author David S. Miller Tue, 28 Jun 2005 22:25:31 +0000 (15:25 -0700) commit 689be43945e9ca7dd704522e55af1b8a73a994d3 "[NET]: Remove gratuitous use of skb->tail in network drivers." The following patch fixes it - please apply (cisco_hard_header does skb_push(4 bytes)). Signed-off-by: David S. Miller --- diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c index 48c03c11cd..a01efa6d5c 100644 --- a/drivers/net/wan/hdlc_cisco.c +++ b/drivers/net/wan/hdlc_cisco.c @@ -72,7 +72,7 @@ static void cisco_keepalive_send(struct net_device *dev, u32 type, } skb_reserve(skb, 4); cisco_hard_header(skb, dev, CISCO_KEEPALIVE, NULL, NULL, 0); - data = (cisco_packet*)skb->data; + data = (cisco_packet*)(skb->data + 4); data->type = htonl(type); data->par1 = htonl(par1);