From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 13 Apr 2010 02:00:03 +0000 (+0200)
Subject: service: add basic validation hooks
X-Git-Tag: 0.git+20100605+dfd8ee-1~136
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=243b1432c6c9e2b92e9fc948e119ebd6e5f4de2b;p=systemd

service: add basic validation hooks
---

diff --git a/service.c b/service.c
index a7af4fde..21e84366 100644
--- a/service.c
+++ b/service.c
@@ -726,6 +726,20 @@ static void service_init(Unit *u) {
         RATELIMIT_INIT(s->ratelimit, 10*USEC_PER_SEC, 5);
 }
 
+static int service_verify(Service *s) {
+        assert(s);
+
+        if (UNIT(s)->meta.load_state != UNIT_LOADED)
+                return 0;
+
+        if (!s->exec_command[SERVICE_EXEC_START]) {
+                log_error("%s lacks ExecStart setting. Refusing.", unit_id(UNIT(s)));
+                return -EINVAL;
+        }
+
+        return 0;
+}
+
 static int service_load(Unit *u) {
         int r;
         Service *s = SERVICE(u);
@@ -762,7 +776,7 @@ static int service_load(Unit *u) {
                         return r;
         }
 
-        return 0;
+        return service_verify(s);
 }
 
 static void service_dump(Unit *u, FILE *f, const char *prefix) {