From: Roland Dreier <rolandd@cisco.com>
Date: Sat, 19 May 2007 15:51:57 +0000 (-0700)
Subject: mlx4_core: Fix array overrun in dump_dev_cap_flags()
X-Git-Tag: v2.6.22-rc3~108^2~6
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=23c15c21d34a4b4b4d7b9a95ce498991c5339c77;p=linux-2.6

mlx4_core: Fix array overrun in dump_dev_cap_flags()

Don't overrun fname[] array when decoding device flags.

This was spotted by the Coverity checker (CID 1642).

Signed-off-by: Roland Dreier <rolandd@cisco.com>
---

diff --git a/drivers/net/mlx4/fw.c b/drivers/net/mlx4/fw.c
index c427173136..cfa5cc0723 100644
--- a/drivers/net/mlx4/fw.c
+++ b/drivers/net/mlx4/fw.c
@@ -90,7 +90,7 @@ static void dump_dev_cap_flags(struct mlx4_dev *dev, u32 flags)
 	int i;
 
 	mlx4_dbg(dev, "DEV_CAP flags:\n");
-	for (i = 0; i < 32; ++i)
+	for (i = 0; i < ARRAY_SIZE(fname); ++i)
 		if (fname[i] && (flags & (1 << i)))
 			mlx4_dbg(dev, "    %s\n", fname[i]);
 }