From: Andy Whitcroft <apw@shadowen.org>
Date: Wed, 22 Aug 2007 04:23:39 +0000 (-0700)
Subject: [IRDA] irda_nl_get_mode: always results in failure
X-Git-Tag: v2.6.23-rc4~92^2
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=22117ea4fef4ea1c7d97c4d68c02c96c268a511b;p=linux-2.6

[IRDA] irda_nl_get_mode: always results in failure

It seems an extraneous trailing ';' has slipped in to the error handling for a
name registration failure causing the error path to trigger unconditionally.

Signed-off-by: Andy Whitcroft <apw@shadowen.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Samuel Ortiz <samuel@sortiz.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/irda/irnetlink.c b/net/irda/irnetlink.c
index 694ea4d92f..1e429c9297 100644
--- a/net/irda/irnetlink.c
+++ b/net/irda/irnetlink.c
@@ -106,7 +106,7 @@ static int irda_nl_get_mode(struct sk_buff *skb, struct genl_info *info)
 	}
 
 	if(nla_put_string(msg, IRDA_NL_ATTR_IFNAME,
-			  dev->name));
+			  dev->name))
 		goto err_out;
 
 	if(nla_put_u32(msg, IRDA_NL_ATTR_MODE, irlap->mode))