From: Ilpo Järvinen Date: Wed, 28 Mar 2007 19:06:37 +0000 (-0700) Subject: [TCP]: Rexmit hint must be cleared instead of setting it X-Git-Tag: v2.6.24-rc1~1454^2~831 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=19b2b486580f5939688d3e225acdc0f4b291ed0d;p=linux-2.6 [TCP]: Rexmit hint must be cleared instead of setting it Stupid error from my side. Even though now that I noticed this, I hoped it would have been an optimization but no, the counter hint is then incorrect. Thus clearing is necessary for now (I still suspect though that this path is never executed). Signed-off-by: Ilpo Järvinen Signed-off-by: David S. Miller --- diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c index 7d843c4293..0aa17243d3 100644 --- a/net/ipv4/tcp_input.c +++ b/net/ipv4/tcp_input.c @@ -1776,7 +1776,7 @@ static void tcp_verify_retransmit_hint(struct tcp_sock *tp, if ((tp->retransmit_skb_hint != NULL) && before(TCP_SKB_CB(skb)->seq, TCP_SKB_CB(tp->retransmit_skb_hint)->seq)) - tp->retransmit_skb_hint = skb; + tp->retransmit_skb_hint = NULL; } /* Mark head of queue up as lost. */