From: Antonino A. Daplas Date: Tue, 10 Jan 2006 04:53:15 +0000 (-0800) Subject: [PATCH] rivafb: Trim rivafb_pan_display X-Git-Tag: v2.6.16-rc1~542 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=198a52a1c490be89a8d5d130eda972630919e0af;p=linux-2.6 [PATCH] rivafb: Trim rivafb_pan_display Remove error checking and updating from rivafb_pan_display. This is guaranteed to be done by the core layer. Signed-off-by: Antonino Daplas Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/video/riva/fbdev.c b/drivers/video/riva/fbdev.c index dd7b2cc888..6c19ab6afb 100644 --- a/drivers/video/riva/fbdev.c +++ b/drivers/video/riva/fbdev.c @@ -1209,32 +1209,8 @@ static int rivafb_pan_display(struct fb_var_screeninfo *var, unsigned int base; NVTRACE_ENTER(); - if (var->xoffset > (var->xres_virtual - var->xres)) - return -EINVAL; - if (var->yoffset > (var->yres_virtual - var->yres)) - return -EINVAL; - - if (var->vmode & FB_VMODE_YWRAP) { - if (var->yoffset < 0 - || var->yoffset >= info->var.yres_virtual - || var->xoffset) return -EINVAL; - } else { - if (var->xoffset + info->var.xres > info->var.xres_virtual || - var->yoffset + info->var.yres > info->var.yres_virtual) - return -EINVAL; - } - base = var->yoffset * info->fix.line_length + var->xoffset; - par->riva.SetStartAddress(&par->riva, base); - - info->var.xoffset = var->xoffset; - info->var.yoffset = var->yoffset; - - if (var->vmode & FB_VMODE_YWRAP) - info->var.vmode |= FB_VMODE_YWRAP; - else - info->var.vmode &= ~FB_VMODE_YWRAP; NVTRACE_LEAVE(); return 0; }