From: Lennart Poettering <lennart@poettering.net>
Date: Tue, 11 Oct 2011 18:21:06 +0000 (+0200)
Subject: service: don't try to guess PID for SysV services anymore
X-Git-Tag: v37~1
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=1835f23c2a53e632959270e79dbf3143874e6111;p=systemd

service: don't try to guess PID for SysV services anymore

As it turns out there are quite a number of SysV services too broken to
make the guessing work: instead of returning in the parent only after
the child is fully initialized they return immediately. The effect is
that the guessing in systemd might happen too early, at a time where the
final main process doesn't exist yet.

By turning this off we won't try to detect the main pid anymore, with
the effect that all processes of the service in question are considered
equally likely to be the main process.
---

diff --git a/src/service.c b/src/service.c
index c2053ce3..e64d289f 100644
--- a/src/service.c
+++ b/src/service.c
@@ -829,6 +829,7 @@ static int service_load_sysv_path(Service *s, const char *path) {
         /* Special setting for all SysV services */
         s->type = SERVICE_FORKING;
         s->remain_after_exit = !s->pid_file;
+        s->guess_main_pid = false;
         s->restart = SERVICE_RESTART_NO;
 
         if (s->meta.manager->sysv_console)