From: Eric W. Biederman <ebiederm@xmission.com>
Date: Mon, 26 Jun 2006 07:25:42 +0000 (-0700)
Subject: [PATCH] proc: Remove unnecessary and misleading assignments from proc_pid_make_inode
X-Git-Tag: v2.6.18-rc1~765
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=167965495153ba9829d0a34b6800dbf5d94de8c8;p=linux-2.6

[PATCH] proc: Remove unnecessary and misleading assignments from proc_pid_make_inode

The removed fields are already set by proc_alloc_inode.  Initializing them in
proc_alloc_inode implies they need it for proper cleanup.  At least ei->pde
was not set on all paths making it look like proc_alloc_inode was buggy.  So
just remove the redundant assignments.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
---

diff --git a/fs/proc/base.c b/fs/proc/base.c
index 7169a713da..0762bc34d9 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -1357,7 +1357,6 @@ static struct inode *proc_pid_make_inode(struct super_block * sb, struct task_st
 
 	/* Common stuff */
 	ei = PROC_I(inode);
-	ei->task = NULL;
 	inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
 	inode->i_ino = fake_ino(task->pid, ino);
 
@@ -1382,7 +1381,6 @@ out:
 	return inode;
 
 out_unlock:
-	ei->pde = NULL;
 	iput(inode);
 	return NULL;
 }