From: Greg Kroah-Hartman <gregkh@suse.de>
Date: Fri, 9 Mar 2007 23:25:04 +0000 (-0800)
Subject: Revert "driver core: refcounting fix"
X-Git-Tag: v2.6.21-rc4~52^2~4
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=161e232b8823e230d4fdf8064e606bbdf26f47e2;p=linux-2.6

Revert "driver core: refcounting fix"

This reverts commit 63ce18cfe685115ff8d341bae4c9204a79043cf0.

It was the incorrect fix and causes a reference counting bug whenever
any driver module is removed from the system. Mike Galbraith
<efault@gmx.de> is looking for the real fix for his problem.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/kernel/module.c b/kernel/module.c
index f77e893e46..fbc51de644 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -2419,12 +2419,6 @@ void module_remove_driver(struct device_driver *drv)
 			kfree(driver_name);
 		}
 	}
-	/*
-	 * Undo the additional reference we added in module_add_driver()
-	 * via kset_find_obj()
-	 */
-	if (drv->mod_name)
-		kobject_put(&drv->kobj);
 }
 EXPORT_SYMBOL(module_remove_driver);
 #endif