From: Maciej W. Rozycki Date: Tue, 16 Oct 2007 08:29:57 +0000 (-0700) Subject: tgafb: remove a redundant non-mono test in mono imageblit X-Git-Tag: v2.6.24-rc1~843 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=102a1a20d2b0a412d4cd4a9f047761f7925405ff;p=linux-2.6 tgafb: remove a redundant non-mono test in mono imageblit There is a test in tgafb_mono_imageblit() for a colour image with a fall-back to cfb_imageblit(). The test is not necessary as the only caller, which is tgafb_imageblit(), checks it too and only invokes this function for monochrome images. It looks like a left-over from before some changes to tgafb_imageblit(). Signed-off-by: Maciej W. Rozycki Cc: Antonino Daplas Cc: Jay Estabrook Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/video/tgafb.c b/drivers/video/tgafb.c index 5539f4d9cb..680642c089 100644 --- a/drivers/video/tgafb.c +++ b/drivers/video/tgafb.c @@ -637,15 +637,6 @@ tgafb_mono_imageblit(struct fb_info *info, const struct fb_image *image) is8bpp = info->var.bits_per_pixel == 8; - /* For copies that aren't pixel expansion, there's little we - can do better than the generic code. */ - /* ??? There is a DMA write mode; I wonder if that could be - made to pull the data from the image buffer... */ - if (image->depth > 1) { - cfb_imageblit(info, image); - return; - } - dx = image->dx; dy = image->dy; width = image->width;