From: David Woodhouse Date: Tue, 11 Dec 2007 20:28:18 +0000 (-0500) Subject: libertas: remove casts from lbs_cmd() and lbs_cmd_with_response() macros X-Git-Tag: v2.6.25-rc1~1162^2~379 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0f1c8232e839e215e38055cd8ae79225ab178185;p=linux-2.6 libertas: remove casts from lbs_cmd() and lbs_cmd_with_response() macros If stupid people like me give it arguments with the wrong type (like a pointer to the structure, for example, instead of the structure itself), then we should probably notice that at compile time. Otherwise, much confusion ensues. Signed-off-by: David Woodhouse Signed-off-by: John W. Linville --- diff --git a/drivers/net/wireless/libertas/cmd.h b/drivers/net/wireless/libertas/cmd.h index 716f25be5b..950acce3ba 100644 --- a/drivers/net/wireless/libertas/cmd.h +++ b/drivers/net/wireless/libertas/cmd.h @@ -7,11 +7,11 @@ #include "dev.h" #define lbs_cmd(priv, cmdnr, cmd, callback, callback_arg) \ - __lbs_cmd(priv, cmdnr, (struct cmd_header *) &cmd, sizeof(cmd), \ + __lbs_cmd(priv, cmdnr, &(cmd).hdr, sizeof(cmd), \ callback, callback_arg) #define lbs_cmd_with_response(priv, cmdnr, cmd) \ - __lbs_cmd(priv, cmdnr, (struct cmd_header *) &cmd, sizeof(cmd), \ + __lbs_cmd(priv, cmdnr, &(cmd).hdr, sizeof(cmd), \ lbs_cmd_copyback, (unsigned long) &cmd) int __lbs_cmd(struct lbs_private *priv, uint16_t command,