From: Daniel Hahler <debian-bugs@thequod.de>
Date: Sun, 1 Jun 2008 08:30:04 +0000 (+0200)
Subject: dpkg-deb: improve error message "unable to extract"
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0ee8807033b96d0933cce5b9f32cdc8a5201ed06;p=dpkg

dpkg-deb: improve error message "unable to extract"

* src/archives.c (tarobject): Improve error message stating that
dpkg is unable to create a file so that it also refers to the real
filename instead of the non-diverted name only.
---

diff --git a/ChangeLog b/ChangeLog
index 0f8f9ad2..3da94553 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2008-06-01  Daniel Hahler  <debian-bugs@thequod.de>
+
+	* src/archives.c (tarobject): Improve error message stating that
+	dpkg is unable to create a file so that it also refers to the real
+	filename instead of the non-diverted name only.
+
 2008-05-31  Raphael Hertzog  <hertzog@debian.org>
 
 	* src/query.c (searchfiles): Trim trailing slashes (and slash dot)
diff --git a/THANKS b/THANKS
index d203253e..096a3442 100644
--- a/THANKS
+++ b/THANKS
@@ -35,6 +35,7 @@ Colin Plumb <colin@nyx.net>
 Colin Watson <cjwatson@debian.org>
 Dafydd Harries <daf@muse.19inch.net>
 Dan Gohman <gohmandj@mrs.umn.edu>
+Daniel Hahler <debian-bugs@thequod.de>
 Daniel Jacobowitz <dan@debian.org>
 Daniel Leidert <daniel.leidert@wgdd.de>
 Daniel Nylander <yeager@lidkoping.net>
diff --git a/debian/changelog b/debian/changelog
index 138de35b..26c5271a 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -20,6 +20,9 @@ dpkg (1.15.0) UNRELEASED; urgency=low
   * Update dpkg(1) to refer to conffile whenever we speak of configuration
     file handled by dpkg. Thus harmonize vocabulary with the policy. Thanks
     to Helge Kreutzmann <debian@helgefjell.de>. Closes: #381219
+  * Improve error message stating that dpkg is unable to create a file so that
+    it also refers to the real filename instead of the non-diverted name only.
+    Thanks to Daniel Hahler for the patch. Closes: #457135
 
   [ Pierre Habouzit ]
   * Add a --query option to update-alternatives. Closes: #336091, #441904
diff --git a/src/archives.c b/src/archives.c
index 50ca0349..5124e1ff 100644
--- a/src/archives.c
+++ b/src/archives.c
@@ -650,7 +650,8 @@ int tarobject(struct TarInfo *ti) {
      * it until we apply the proper mode, which might be a statoverride.
      */
     fd= open(fnamenewvb.buf, (O_CREAT|O_EXCL|O_WRONLY), 0);
-    if (fd < 0) ohshite(_("unable to create `%.255s'"),ti->Name);
+    if (fd < 0)
+      ohshite(_("unable to create `%.255s' (while processing `%.255s')"), fnamenewvb.buf, ti->Name);
     push_cleanup(cu_closefd, ehflag_bombout, NULL, 0, 1, &fd);
     debug(dbg_eachfiledetail,"tarobject NormalFile[01] open size=%lu",
           (unsigned long)ti->Size);