From: Li Zefan Date: Fri, 8 Feb 2008 12:19:24 +0000 (-0800) Subject: clockevent: simplify list operations X-Git-Tag: v2.6.25-rc1~200 X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0b858e6ff9a38b987a83d22e6f2a2f621c80608d;p=linux-2.6 clockevent: simplify list operations list_for_each_safe() suffices here. Signed-off-by: Li Zefan Cc: Thomas Gleixner Cc: Ingo Molnar Cc: john stultz Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index 3e59fce6dd..1d327f6db4 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time/clockevents.c @@ -218,6 +218,8 @@ void clockevents_exchange_device(struct clock_event_device *old, */ void clockevents_notify(unsigned long reason, void *arg) { + struct list_head *node, *tmp; + spin_lock(&clockevents_lock); clockevents_do_notify(reason, arg); @@ -227,13 +229,8 @@ void clockevents_notify(unsigned long reason, void *arg) * Unregister the clock event devices which were * released from the users in the notify chain. */ - while (!list_empty(&clockevents_released)) { - struct clock_event_device *dev; - - dev = list_entry(clockevents_released.next, - struct clock_event_device, list); - list_del(&dev->list); - } + list_for_each_safe(node, tmp, &clockevents_released) + list_del(node); break; default: break;