From: des <des@d4fa192b-c00b-0410-8231-f00ffab90ce4>
Date: Tue, 18 Dec 2007 16:47:44 +0000 (+0000)
Subject: Add $NOTES as a hack to document the fact that we know 1.1.2 fails some of
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=0a2be29d7dac4cc9ded105c471a5c3d19a7b407a;p=varnish

Add $NOTES as a hack to document the fact that we know 1.1.2 fails some of
the tests.  This should be revisited later; ideally, the framework should
know which tests are expected to pass and which are expected to fail, and
flag any deviation (if a test is expected to fail but passes, it is
probable that the test is broken)


git-svn-id: svn+ssh://projects.linpro.no/svn/varnish/trunk@2297 d4fa192b-c00b-0410-8231-f00ffab90ce4
---

diff --git a/varnish-tools/regress/lib/Varnish/Test/Case.pm b/varnish-tools/regress/lib/Varnish/Test/Case.pm
index c57fd8fd..6fb92df2 100644
--- a/varnish-tools/regress/lib/Varnish/Test/Case.pm
+++ b/varnish-tools/regress/lib/Varnish/Test/Case.pm
@@ -232,9 +232,11 @@ sub results($) {
     no strict 'refs';
     my $name = ${ref($self)."::NAME"} || (split('::', ref($self)))[-1];
     my $descr = ${ref($self)."::DESCR"} || "N/A";
+    my $notes = ${ref($self)."::NOTES"} || "N/A";
     return {
 	'name' => $name,
 	'descr' => $descr,
+	'notes' => $notes,
 	'count' => $self->{'count'},
 	'pass' => $self->{'successful'},
 	'fail' => $self->{'failed'},
diff --git a/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm b/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm
index 76eb9f1b..fd9bf4fa 100644
--- a/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm
+++ b/varnish-tools/regress/lib/Varnish/Test/Case/POST.pm
@@ -35,6 +35,7 @@ use base 'Varnish::Test::Case';
 
 our $DESCR = "Tests Varnish's ability to correctly pass POST requests" .
     " to the backend, and their replies back to the client.";
+our $NOTES = "1.1.2 is expected to fail one of three subtests.";
 
 our $VCL = <<EOVCL;
 sub vcl_recv {
diff --git a/varnish-tools/regress/lib/Varnish/Test/Case/Pipeline.pm b/varnish-tools/regress/lib/Varnish/Test/Case/Pipeline.pm
index fd122b77..0e891855 100644
--- a/varnish-tools/regress/lib/Varnish/Test/Case/Pipeline.pm
+++ b/varnish-tools/regress/lib/Varnish/Test/Case/Pipeline.pm
@@ -34,6 +34,7 @@ use strict;
 use base 'Varnish::Test::Case';
 
 our $DESCR = "Tests Varnish's ability to handle pipelined requests.";
+our $NOTES = "1.1.2 is expected to fail one of two subtests.";
 
 our %CONTENT = (
     'Gibson' => "The sky above the port was the color of television, tuned to a dead channel.",
diff --git a/varnish-tools/regress/lib/Varnish/Test/Report/report.html b/varnish-tools/regress/lib/Varnish/Test/Report/report.html
index 856c418e..9ea4526e 100644
--- a/varnish-tools/regress/lib/Varnish/Test/Report/report.html
+++ b/varnish-tools/regress/lib/Varnish/Test/Report/report.html
@@ -16,7 +16,8 @@ tr.fail { background-color: #ffeeee; }
 .pass { width: 5%; }
 .fail { width: 5%; }
 .time { width: 5%; text-align: right; }
-.descr { width: 70%; }
+.descr { width: 50%; }
+.notes { width: 20%; }
     </style>
   </head>
 <!-- USE ms = format('%5.3f') -->
@@ -31,6 +32,7 @@ tr.fail { background-color: #ffeeee; }
 	  <th class="fail">Fail</th>
 	  <th class="time">Time</th>
 	  <th class="descr">Description</th>
+	  <th class="notes">Notes</th>
 	</tr>
       </thead>
 <!-- FOREACH case = cases -->
@@ -45,6 +47,7 @@ tr.fail { background-color: #ffeeee; }
 	<td class="fail"><!-- case.fail --></td>
 	<td class="time"><!-- ms(case.time) --> s</td>
 	<td class="descr"><!-- case.descr --></td>
+	<td class="notes"><!-- case.notes --></td>
       </tr>
 <!-- END -->
       <tfoot>
@@ -55,6 +58,7 @@ tr.fail { background-color: #ffeeee; }
 	  <td class="fail"><!-- fail --></td>
 	  <td class="time"><!-- ms(time) --> s</td>
 	  <td class="descr">&nbsp;</td>
+	  <td class="notes">&nbsp;</td>
 	</tr>
       </tfoot>
     </table>