From: helge <helge@e4a50df8-12e2-0310-a44c-efbce7f8a7e3>
Date: Thu, 17 Nov 2005 17:15:32 +0000 (+0000)
Subject: fixed gstep-base compile warnings
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=07ae473e63a67e2cd55a1ee1f002ff8558250652;p=sope

fixed gstep-base compile warnings


git-svn-id: http://svn.opengroupware.org/SOPE/trunk@1179 e4a50df8-12e2-0310-a44c-efbce7f8a7e3
---

diff --git a/sope-appserver/NGObjWeb/Associations/WOKeyPathAssociation.m b/sope-appserver/NGObjWeb/Associations/WOKeyPathAssociation.m
index 0146c488..32b1a221 100644
--- a/sope-appserver/NGObjWeb/Associations/WOKeyPathAssociation.m
+++ b/sope-appserver/NGObjWeb/Associations/WOKeyPathAssociation.m
@@ -23,6 +23,7 @@
 #include <NGObjWeb/WOComponent.h>
 #include "NSObject+WO.h"
 #include "common.h"
+#include <string.h>
 
 #if LIB_FOUNDATION_BOEHM_GC
 #  if LIB_FOUNDATION_LIBRARY
diff --git a/sope-appserver/NGObjWeb/ChangeLog b/sope-appserver/NGObjWeb/ChangeLog
index a3f44cf4..a35535aa 100644
--- a/sope-appserver/NGObjWeb/ChangeLog
+++ b/sope-appserver/NGObjWeb/ChangeLog
@@ -1,3 +1,11 @@
+2005-11-17  Helge Hess  <helge.hess@opengroupware.org>
+
+	* v4.5.212
+
+	* DynamicElements/WOCopyValue.m: fixed a gcc3 warning
+
+	* include string.h where required
+
 2005-11-13  Helge Hess  <helge.hess@opengroupware.org>
 
 	* DynamicElements/WORadioButton.m: added some comments and a warning
diff --git a/sope-appserver/NGObjWeb/DynamicElements/WOCopyValue.m b/sope-appserver/NGObjWeb/DynamicElements/WOCopyValue.m
index deb34798..78309faa 100644
--- a/sope-appserver/NGObjWeb/DynamicElements/WOCopyValue.m
+++ b/sope-appserver/NGObjWeb/DynamicElements/WOCopyValue.m
@@ -204,7 +204,7 @@ static inline id valueForConstString(NSString *v) {
     
     value = [_d objectForKey:key];
     if ([value isKindOfClass:[NSString class]]) {
-      value = [value hasPrefix:@"const:"]
+      value = [(NSString *)value hasPrefix:@"const:"]
 	? valueForConstString(value)
 	: [getCursor valueForKeyPath:value];
     }
diff --git a/sope-appserver/NGObjWeb/DynamicElements/WOString.m b/sope-appserver/NGObjWeb/DynamicElements/WOString.m
index baf90e4d..dc59cf93 100644
--- a/sope-appserver/NGObjWeb/DynamicElements/WOString.m
+++ b/sope-appserver/NGObjWeb/DynamicElements/WOString.m
@@ -22,6 +22,7 @@
 #include "WOHTMLDynamicElement.h"
 #include "WOElement+private.h"
 #include "decommon.h"
+#include <string.h>
 #import <Foundation/NSNumberFormatter.h>
 #import <Foundation/NSDateFormatter.h>
 
diff --git a/sope-appserver/NGObjWeb/NGHttp+WO.m b/sope-appserver/NGObjWeb/NGHttp+WO.m
index d19caa61..d3bd3b08 100644
--- a/sope-appserver/NGObjWeb/NGHttp+WO.m
+++ b/sope-appserver/NGObjWeb/NGHttp+WO.m
@@ -25,6 +25,7 @@
 #include <NGObjWeb/WORequest.h>
 #include <NGMime/NGMime.h>
 #include "common.h"
+#include <string.h>
 
 @interface WORequest(NGSupport)
 - (void)_setHttpRequest:(NGHttpRequest *)_request;
diff --git a/sope-appserver/NGObjWeb/NSObject+WO.m b/sope-appserver/NGObjWeb/NSObject+WO.m
index 64128f9f..cb8dba33 100644
--- a/sope-appserver/NGObjWeb/NSObject+WO.m
+++ b/sope-appserver/NGObjWeb/NSObject+WO.m
@@ -21,6 +21,7 @@
 
 #include "NSObject+WO.h"
 #include "common.h"
+#include <string.h>
 
 #if APPLE_RUNTIME || NeXT_RUNTIME
 #  include <objc/objc-class.h>
diff --git a/sope-appserver/NGObjWeb/Version b/sope-appserver/NGObjWeb/Version
index 09f51d76..1ff73710 100644
--- a/sope-appserver/NGObjWeb/Version
+++ b/sope-appserver/NGObjWeb/Version
@@ -1,6 +1,6 @@
 # version file
 
-SUBMINOR_VERSION:=211
+SUBMINOR_VERSION:=212
 
 # v4.5.122 requires libNGExtensions v4.5.153
 # v4.5.91  requires libNGExtensions v4.5.134
diff --git a/sope-appserver/NGObjWeb/WOHttpAdaptor/WOHttpAdaptor.m b/sope-appserver/NGObjWeb/WOHttpAdaptor/WOHttpAdaptor.m
index fcea5bad..cabb78de 100644
--- a/sope-appserver/NGObjWeb/WOHttpAdaptor/WOHttpAdaptor.m
+++ b/sope-appserver/NGObjWeb/WOHttpAdaptor/WOHttpAdaptor.m
@@ -45,6 +45,7 @@
 #include "WORecordRequestStream.h"
 #include "WOHttpTransaction.h"
 
+#include <string.h>
 #include <unistd.h>
 #include <sys/wait.h>
 
diff --git a/sope-appserver/NGObjWeb/WOHttpAdaptor/WOHttpTransaction.m b/sope-appserver/NGObjWeb/WOHttpAdaptor/WOHttpTransaction.m
index 91c3823d..f2a1530d 100644
--- a/sope-appserver/NGObjWeb/WOHttpAdaptor/WOHttpTransaction.m
+++ b/sope-appserver/NGObjWeb/WOHttpAdaptor/WOHttpTransaction.m
@@ -33,6 +33,7 @@
 #include <NGHttp/NGHttp.h>
 #include "common.h"
 
+#include <string.h>
 #include <sys/time.h>
 
 @interface WORequest(UsedPrivates)
diff --git a/sope-appserver/NGObjWeb/WOMessage.m b/sope-appserver/NGObjWeb/WOMessage.m
index 6756fa15..f46d659a 100644
--- a/sope-appserver/NGObjWeb/WOMessage.m
+++ b/sope-appserver/NGObjWeb/WOMessage.m
@@ -23,6 +23,7 @@
 #include <NGExtensions/NGHashMap.h>
 #include <NGExtensions/NSString+misc.h>
 #include "common.h"
+#include <string.h>
 
 // #define STRIP_MULTIPLE_SPACES // this doesn't work with <pre> tags !
 
diff --git a/sope-appserver/NGObjWeb/WOSession.m b/sope-appserver/NGObjWeb/WOSession.m
index f0e8f745..4a957203 100644
--- a/sope-appserver/NGObjWeb/WOSession.m
+++ b/sope-appserver/NGObjWeb/WOSession.m
@@ -30,6 +30,7 @@
 #include <NGObjWeb/WOStatisticsStore.h>
 #include <EOControl/EONull.h>
 #include "common.h"
+#include <string.h>
 
 #if APPLE_FOUNDATION_LIBRARY || NeXT_Foundation_LIBRARY
 @interface NSObject(Miss)
diff --git a/sope-appserver/NGObjWeb/WOSimpleHTTPParser.m b/sope-appserver/NGObjWeb/WOSimpleHTTPParser.m
index c76fb0cf..184194fd 100644
--- a/sope-appserver/NGObjWeb/WOSimpleHTTPParser.m
+++ b/sope-appserver/NGObjWeb/WOSimpleHTTPParser.m
@@ -23,6 +23,7 @@
 #include <NGObjWeb/WOResponse.h>
 #include <NGObjWeb/WORequest.h>
 #include "common.h"
+#include <string.h>
 
 @implementation WOSimpleHTTPParser
 
diff --git a/sope-appserver/NGObjWeb/WOWatchDogApplicationMain.m b/sope-appserver/NGObjWeb/WOWatchDogApplicationMain.m
index bd8d5f7e..47e817d8 100644
--- a/sope-appserver/NGObjWeb/WOWatchDogApplicationMain.m
+++ b/sope-appserver/NGObjWeb/WOWatchDogApplicationMain.m
@@ -40,6 +40,7 @@ int WOWatchDogApplicationMain
 #include <sys/types.h>
 #include <sys/unistd.h>
 #include <time.h>
+#include <string.h>
 
 static pid_t    child = -1;
 static NSString *pidFile = nil;
diff --git a/sope-appserver/NGObjWeb/WebDAV/SoDAVSQLParser.m b/sope-appserver/NGObjWeb/WebDAV/SoDAVSQLParser.m
index fa72fcbf..4644b1fa 100644
--- a/sope-appserver/NGObjWeb/WebDAV/SoDAVSQLParser.m
+++ b/sope-appserver/NGObjWeb/WebDAV/SoDAVSQLParser.m
@@ -25,6 +25,7 @@
 #include <EOControl/EOSortOrdering.h>
 #include <EOControl/EOClassDescription.h>
 #include "common.h"
+#include <string.h>
 
 // TODO: better error output
 
diff --git a/sope-core/NGExtensions/ChangeLog b/sope-core/NGExtensions/ChangeLog
index 1634fed9..93a9bdbf 100644
--- a/sope-core/NGExtensions/ChangeLog
+++ b/sope-core/NGExtensions/ChangeLog
@@ -1,5 +1,8 @@
 2005-11-17  Helge Hess  <helge.hess@opengroupware.org>
 
+	* FdExt.subproj/NSObject+Values.m: explicitly mark signed values as
+	  such (most importantly char) (v4.5.178)
+
 	* FdExt.subproj/NSCalendarDate+misc.m: include math.h to avoid a floor
 	  warning (v4.5.177)
 
diff --git a/sope-core/NGExtensions/FdExt.subproj/NSObject+Values.m b/sope-core/NGExtensions/FdExt.subproj/NSObject+Values.m
index e0565567..5cff0bd7 100644
--- a/sope-core/NGExtensions/FdExt.subproj/NSObject+Values.m
+++ b/sope-core/NGExtensions/FdExt.subproj/NSObject+Values.m
@@ -29,34 +29,34 @@
   return YES;
 }
 
-- (char)charValue {
+- (signed char)charValue {
   return (char)[self intValue];
 }
 - (unsigned char)unsignedCharValue {
   return (unsigned char)[self intValue];
 }
-- (short)shortValue {
+- (signed short)shortValue {
   return (short)[self intValue];
 }
 - (unsigned short)unsignedShortValue {
   return (unsigned short)[self unsignedIntValue];
 }
 
-- (int)intValue {
+- (signed int)intValue {
   return [[self stringValue] intValue];
 }
 - (unsigned int)unsignedIntValue {
   return (unsigned int)[self intValue];
 }
 
-- (long)longValue {
+- (signed long)longValue {
   return (long)[self intValue];
 }
 - (unsigned long)unsignedLongValue {
   return (unsigned long)[self unsignedIntValue];
 }
 
-- (long long)longLongValue {
+- (signed long long)longLongValue {
   return [[self stringValue] longLongValue];
 }
 - (unsigned long long)unsignedLongLongValue {
diff --git a/sope-core/NGExtensions/NGExtensions/NSObject+Values.h b/sope-core/NGExtensions/NGExtensions/NSObject+Values.h
index de085da7..d9a3c0bb 100644
--- a/sope-core/NGExtensions/NGExtensions/NSObject+Values.h
+++ b/sope-core/NGExtensions/NGExtensions/NSObject+Values.h
@@ -29,16 +29,19 @@
 
 - (BOOL)boolValue; // this returns always YES (the id != nil)
 
-// these methods perform their operation on the string-representation of the object
-- (char)charValue;
+/*
+  these methods perform their operation on the string-representation of the
+  object
+*/
+- (signed char)charValue;
 - (unsigned char)unsignedCharValue;
-- (short)shortValue;
+- (signed short)shortValue;
 - (unsigned short)unsignedShortValue;
-- (int)intValue;
+- (signed int)intValue;
 - (unsigned int)unsignedIntValue;
-- (long)longValue;
+- (signed long)longValue;
 - (unsigned long)unsignedLongValue;
-- (long long)longLongValue;
+- (signed long long)longLongValue;
 - (unsigned long long)unsignedLongLongValue;
 - (float)floatValue;
 - (double)doubleValue;
diff --git a/sope-core/NGExtensions/Version b/sope-core/NGExtensions/Version
index 0cc913d1..d6b947f0 100644
--- a/sope-core/NGExtensions/Version
+++ b/sope-core/NGExtensions/Version
@@ -1,6 +1,6 @@
 # version
 
-SUBMINOR_VERSION:=177
+SUBMINOR_VERSION:=178
 
 # v4.3.115 requires libFoundation v1.0.59
 # v4.2.72  requires libEOControl  v4.2.39