From: Oleg Nesterov <oleg@tv-sign.ru>
Date: Wed, 17 Oct 2007 06:26:47 +0000 (-0700)
Subject: do_sigaction: remove now unneeded recalc_sigpending()
X-Git-Tag: v2.6.24-rc1~718
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=045f902de5a6eb5927c0f092c38be7a381f634f0;p=linux-2.6

do_sigaction: remove now unneeded recalc_sigpending()

With the recent changes, do_sigaction()->recalc_sigpending_and_wake() can
never clear TIF_SIGPENDING. Instead, it can set this flag and wake up the
thread without any reason. Harmless, but unneeded and wastes CPU.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Roland McGrath <roland@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
---

diff --git a/kernel/signal.c b/kernel/signal.c
index 7929523810..2f7736ff74 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -2335,7 +2335,6 @@ int do_sigaction(int sig, struct k_sigaction *act, struct k_sigaction *oact)
 			rm_from_queue_full(&mask, &t->signal->shared_pending);
 			do {
 				rm_from_queue_full(&mask, &t->pending);
-				recalc_sigpending_and_wake(t);
 				t = next_thread(t);
 			} while (t != current);
 		}