From: Tejun Heo <htejun@gmail.com>
Date: Fri, 26 Jan 2007 11:10:25 +0000 (+0900)
Subject: libata: fix ata_eh_suspend() return value
X-Git-Tag: v2.6.20-rc7~14^2~6
X-Git-Url: https://err.no/cgi-bin/gitweb.cgi?a=commitdiff_plain;h=03ee5b1cdd09ed1ee2e75d0bc647fc5db66b9d07;p=linux-2.6

libata: fix ata_eh_suspend() return value

ata_eh_suspend() was returning 0 regardless of failure.  This bug has
potential to lose data on suspend.  Fix it.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
---

diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
index 56cf59b60e..748435807d 100644
--- a/drivers/ata/libata-eh.c
+++ b/drivers/ata/libata-eh.c
@@ -1796,7 +1796,7 @@ static int ata_eh_suspend(struct ata_port *ap, struct ata_device **r_failed_dev)
 		*r_failed_dev = dev;
 
 	DPRINTK("EXIT\n");
-	return 0;
+	return rc;
 }
 
 /**