]> err.no Git - linux-2.6/commitdiff
mac80211: add missing "break" statement in mesh code
authorJohannes Berg <johannes@sipsolutions.net>
Mon, 25 Feb 2008 09:11:50 +0000 (10:11 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Thu, 6 Mar 2008 20:30:43 +0000 (15:30 -0500)
This inserts a missing break statement which, if hit, would cause
the code to fall-through and unlock a spinlock twice. Noticed via
sparse's "lock count wrong in basic block" warning and careful
code inspection.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Luis Carlos Cobo <luisca@cozybit.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
net/mac80211/mesh_plink.c

index 0b0e8d7eb9c74ffe5f56d689ab7c2055d2df3e79..c2f4fe7a30b6b866fd56abb107e2ebc4eff6ac8d 100644 (file)
@@ -691,6 +691,7 @@ void mesh_rx_plink_frame(struct net_device *dev, struct ieee80211_mgmt *mgmt,
                        spin_unlock_bh(&sta->plink_lock);
                        mesh_plink_frame_tx(dev, PLINK_CLOSE, sta->addr, llid,
                                            plid, reason);
+                       break;
                case OPN_ACPT:
                        if (del_timer(&sta->plink_timer))
                                sta_info_put(sta);