umount: do not sync() as the kernel does it by itself

On Fri, May 21, 2010 at 08:00:09AM -0400, Christoph Hellwig wrote:
> On Fri, May 21, 2010 at 01:55:17PM +0200, Petr Uzel wrote:
> > SUSE-based distributions have the following patch for some time. More
> > info here: https://bugzilla.novell.com/show_bug.cgi?id=447036
> >
> > From the Novell bugzilla:
> > <quote>
> > > I cannot see any justification for that sync call at all so I'd
> > > probably just remove it.  Your
> > > patch is possibly safer so maybe it should be used as is.
> > </quote>
> >
> > So, does anybody know why/if the sync() is actually needed?
>
> It's not needed.  The kernel performs a sync by itself.

Thanks, Christoph.

Signed-off-by: Petr Uzel <petr.uzel@suse.cz>

diff --git a/mount/umount.c b/mount/umount.c
index 6786ac57ccd6191bf46023687a8dc7acaa2b74eb..75507b76a60b376b367ba816b7acd4bab045a431 100644 (file)
--- a/mount/umount.c
+++ b/mount/umount.c
@@ -379,7 +379,6 @@ umount_all (char *types, char *test_opts) {
          }
      }
 
-     sync ();
      return errors;
 }