]> err.no Git - linux-2.6/commitdiff
[SCSI] libsas: sysfs phy control attributes should not be S_IWUGO
authorDarrick J. Wong <djwong@us.ibm.com>
Thu, 11 Jan 2007 22:15:35 +0000 (14:15 -0800)
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>
Sat, 13 Jan 2007 22:20:03 +0000 (16:20 -0600)
Allowing the phy reset controls to be world-triggerable does not seem like
a terribly good idea because SAS devices can be disrupted (and ATA devices
are really disrupted) by a phy reset.  By default only root should be able
to do things like that.

Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/scsi_transport_sas.c

index e57b02e8afa580c03e064790cae8928eefeb1dd8..bfbcf5fa72b963ad3d08bbc8e4c8f54512ee30f0 100644 (file)
@@ -1446,10 +1446,10 @@ static int sas_user_scan(struct Scsi_Host *shost, uint channel,
        SETUP_TEMPLATE(phy_attrs, field, S_IRUGO, i->f->func)
 
 #define SETUP_PHY_ATTRIBUTE_WRONLY(field)                              \
-       SETUP_TEMPLATE(phy_attrs, field, S_IWUGO, 1)
+       SETUP_TEMPLATE(phy_attrs, field, S_IWUSR, 1)
 
 #define SETUP_OPTIONAL_PHY_ATTRIBUTE_WRONLY(field, func)               \
-       SETUP_TEMPLATE(phy_attrs, field, S_IWUGO, i->f->func)
+       SETUP_TEMPLATE(phy_attrs, field, S_IWUSR, i->f->func)
 
 #define SETUP_END_DEV_ATTRIBUTE(field)                                 \
        SETUP_TEMPLATE(end_dev_attrs, field, S_IRUGO, 1)