]> err.no Git - linux-2.6/commitdiff
[NETFILTER]: PPTP conntrack: fix GRE keymap leak
authorPatrick McHardy <kaber@trash.net>
Wed, 20 Sep 2006 19:11:12 +0000 (12:11 -0700)
committerDavid S. Miller <davem@sunset.davemloft.net>
Fri, 22 Sep 2006 22:20:19 +0000 (15:20 -0700)
When destroying the GRE expectations without having seen the GRE connection
the keymap entry is not freed, leading to a memory leak and, in case of
a following call within the same session, failure during expectation setup.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/netfilter/ip_conntrack_helper_pptp.c

index b0225b65ca3518154ee33f69ffb57a8378f043e8..98267b0d2a47682b034e60104799f8062797c5ba 100644 (file)
@@ -194,6 +194,7 @@ static void pptp_destroy_siblings(struct ip_conntrack *ct)
 {
        struct ip_conntrack_tuple t;
 
+       ip_ct_gre_keymap_destroy(ct);
        /* Since ct->sibling_list has literally rusted away in 2.6.11,
         * we now need another way to find out about our sibling
         * contrack and expects... -HW */