]> err.no Git - linux-2.6/commitdiff
[ARM] 4557/1: Fix PXA irq gpio initialization
authorSamuel <sameo@openedhand.com>
Tue, 28 Aug 2007 18:56:34 +0000 (19:56 +0100)
committerRussell King <rmk+kernel@arm.linux.org.uk>
Tue, 28 Aug 2007 21:59:43 +0000 (22:59 +0100)
As pointed out by Jrgen, we are overflowing the number of GPIOs
in pxa_init_irq_gpio(). I'm seeing the same problem on my HTC
Universal PXA270 based PDA.
According to Eric, the function argument is the number of GPIOs,
so we should keep the semantics and reduce the number of
iteration by 1.

Signed-off-by: Samuel Ortiz <sameo@openedhand.com>
Acked-by: Jrgen Schindele <linux@schindele.name>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
arch/arm/mach-pxa/irq.c

index 4b867b0789d54c8a9e463e08fbce0cf1f239db61..ae2ae08032d7183a86ab531147066292ffe11070 100644 (file)
@@ -365,7 +365,7 @@ void __init pxa_init_irq_gpio(int gpio_nr)
                set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);
        }
 
-       for (irq = IRQ_GPIO(2); irq <= IRQ_GPIO(gpio_nr); irq++) {
+       for (irq = IRQ_GPIO(2); irq < IRQ_GPIO(gpio_nr); irq++) {
                set_irq_chip(irq, &pxa_muxed_gpio_chip);
                set_irq_handler(irq, handle_edge_irq);
                set_irq_flags(irq, IRQF_VALID | IRQF_PROBE);