]> err.no Git - linux-2.6/commitdiff
sunhme: Remove stop/wake TX queue calls in set-multicast-list handler.
authorDavid S. Miller <davem@davemloft.net>
Mon, 21 Jul 2008 15:34:49 +0000 (08:34 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 21 Jul 2008 15:34:49 +0000 (08:34 -0700)
Based upon a bug report by Alexander Beregalov and commentary
from Ben Hutchings.

These are totally unnecessary, in particular because this
driver's ->hard_start_xmit() handler takes the same driver
spinlock that the set-multicast-list handler uses.

Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/sunhme.c

index 1aa425be306720f6928f06b8b1e97140d73f4492..b79d5f018f798abf59f7822b9def0a483b143cb6 100644 (file)
@@ -2377,8 +2377,6 @@ static void happy_meal_set_multicast(struct net_device *dev)
 
        spin_lock_irq(&hp->happy_lock);
 
-       netif_stop_queue(dev);
-
        if ((dev->flags & IFF_ALLMULTI) || (dev->mc_count > 64)) {
                hme_write32(hp, bregs + BMAC_HTABLE0, 0xffff);
                hme_write32(hp, bregs + BMAC_HTABLE1, 0xffff);
@@ -2410,8 +2408,6 @@ static void happy_meal_set_multicast(struct net_device *dev)
                hme_write32(hp, bregs + BMAC_HTABLE3, hash_table[3]);
        }
 
-       netif_wake_queue(dev);
-
        spin_unlock_irq(&hp->happy_lock);
 }