]> err.no Git - linux-2.6/commitdiff
AFS: clean up explicit check for mandatory locks
authorPavel Emelyanov <xemul@openvz.org>
Mon, 1 Oct 2007 21:41:14 +0000 (14:41 -0700)
committerJ. Bruce Fields <bfields@citi.umich.edu>
Tue, 9 Oct 2007 22:32:46 +0000 (18:32 -0400)
The __mandatory_lock(inode) macro makes the same check, but makes the code
more readable.

Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/afs/flock.c

index af6952e39a186c2fd9bbc05411320eb81415575c..210acafe4a9b5d1ec4e5d919e474497c22073ba2 100644 (file)
@@ -524,8 +524,7 @@ int afs_lock(struct file *file, int cmd, struct file_lock *fl)
               (long long) fl->fl_start, (long long) fl->fl_end);
 
        /* AFS doesn't support mandatory locks */
-       if ((vnode->vfs_inode.i_mode & (S_ISGID | S_IXGRP)) == S_ISGID &&
-           fl->fl_type != F_UNLCK)
+       if (__mandatory_lock(&vnode->vfs_inode) && fl->fl_type != F_UNLCK)
                return -ENOLCK;
 
        if (IS_GETLK(cmd))