]> err.no Git - linux-2.6/commitdiff
IB/uverbs: Fix check of is_closed flag check in ib_uverbs_async_handler()
authorJack Morgenstein <jackm@dev.mellanox.co.il>
Wed, 18 Jun 2008 22:36:38 +0000 (15:36 -0700)
committerRoland Dreier <rolandd@cisco.com>
Wed, 18 Jun 2008 22:36:38 +0000 (15:36 -0700)
Commit 1ae5c187 ("IB/uverbs: Don't store struct file * for event
files") changed the way that closed files are handled in the uverbs
code.  However, after the conversion, is_closed flag is checked
incorrectly in ib_uverbs_async_handler().  As a result, no async
events are ever passed to applications.

Found by: Ronni Zimmerman <ronniz@mellanox.co.il>

Signed-off-by: Jack Morgenstein <jackm@dev.mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
drivers/infiniband/core/uverbs_main.c

index f806da184b51b4fe835c51af5f9aa34df5929d8c..caed42bf7ef57b3adcdc5e7ec158361d37d78860 100644 (file)
@@ -423,7 +423,7 @@ static void ib_uverbs_async_handler(struct ib_uverbs_file *file,
        unsigned long flags;
 
        spin_lock_irqsave(&file->async_file->lock, flags);
-       if (!file->async_file->is_closed) {
+       if (file->async_file->is_closed) {
                spin_unlock_irqrestore(&file->async_file->lock, flags);
                return;
        }