]> err.no Git - linux-2.6/commitdiff
[SCSI] qla2xxx: Don't depend on mailbox return values while enabling FCE tracing.
authorAndrew Vasquez <andrew.vasquez@qlogic.com>
Tue, 13 May 2008 05:21:12 +0000 (22:21 -0700)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Thu, 15 May 2008 15:39:29 +0000 (16:39 +0100)
Recent firmwares no longer return the 'number of buffers' in
mailbox6.  The original code may result in a potential panic
during a FW-dump process due to the driver misinterpreting the
size of the allocated buffer.

Signed-off-by: Andrew Vasquez <andrew.vasquez@qlogic.com>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/qla2xxx/qla_mbx.c

index 3800876f96c37223fdda9026e5ae4cd8263acc2c..bf3a6f0b8ba2fbb405449dc868a80796ded7ad76 100644 (file)
@@ -2508,7 +2508,7 @@ qla2x00_enable_fce_trace(scsi_qla_host_t *ha, dma_addr_t fce_dma,
                if (mb)
                        memcpy(mb, mcp->mb, 8 * sizeof(*mb));
                if (dwords)
-                       *dwords = mcp->mb[6];
+                       *dwords = buffers;
        }
 
        return rval;