]> err.no Git - linux-2.6/commitdiff
[XFS] Remove bogus assert
authorNiv Sardi <xaiki@sgi.com>
Tue, 27 Nov 2007 06:01:13 +0000 (17:01 +1100)
committerLachlan McIlroy <lachlan@redback.melbourne.sgi.com>
Thu, 7 Feb 2008 07:17:39 +0000 (18:17 +1100)
This assert is bogus. We can have a forced shutdown occur
between the check for the XLOG_FORCED_SHUTDOWN and the ASSERT. Also, the
logging system shouldn't care about the state of XFS_FORCED_SHUTDOWN, it
should only check XLOG_FORCED_SHUTDOWN. The logging system has it's own
forced shutdown flag so, for the case of a forced shutdown that's not due
to a logging error, we can flush the log.

SGI-PV: 972985
SGI-Modid: xfs-linux-melb:xfs-kern:30029a

Signed-off-by: Niv Sardi <xaiki@sgi.com>
Signed-off-by: David Chinner <dgc@sgi.com>
Signed-off-by: Lachlan McIlroy <lachlan@sgi.com>
fs/xfs/xfs_log.c

index 301a6b8c2034589a9c3a67dd81fc14042bbdff97..7ed15bdc32bfe9c97e9b112b6ad4f959367ebd10 100644 (file)
@@ -764,7 +764,6 @@ xfs_log_move_tail(xfs_mount_t       *mp,
 
        if (XLOG_FORCED_SHUTDOWN(log))
                return;
-       ASSERT(!XFS_FORCED_SHUTDOWN(mp));
 
        if (tail_lsn == 0) {
                /* needed since sync_lsn is 64 bits */