]> err.no Git - linux-2.6/commitdiff
[SCSI] megaraid: Use the proper type to hold the irq number.
authorEric W. Biederman <ebiederm@xmission.com>
Mon, 25 Sep 2006 23:59:01 +0000 (16:59 -0700)
committerJames Bottomley <jejb@mulgrave.il.steeleye.com>
Tue, 26 Sep 2006 17:39:55 +0000 (10:39 -0700)
When testing on a Unisys machine it was discovered that the megaraid driver
would not initialize as it was requesting irq 162 instead of irq 1442 it
was assigned.  The problem was the irq number had been truncated by being
stored in an unsigned char.

This patches fixes that problem and the driver now appears to work.

The ioctl interface appears fundamentally broken as it exports the irq
number to user space in an unsigned char.

Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/scsi/megaraid/mega_common.h

index 8cd0bd1d0f7c1b65393e8bf240e6ac8fdd28a37b..b50e27e660244ebf6e11a79adb8543557981742b 100644 (file)
@@ -175,7 +175,7 @@ typedef struct {
        uint8_t                 max_lun;
 
        uint32_t                unique_id;
-       uint8_t                 irq;
+       int                     irq;
        uint8_t                 ito;
        caddr_t                 ibuf;
        dma_addr_t              ibuf_dma_h;