]> err.no Git - linux-2.6/commitdiff
[CPUFREQ] Don't free held mutex in cpufreq_add_dev()
authorAndrew Morton <akpm@osdl.org>
Wed, 18 Jan 2006 21:40:54 +0000 (13:40 -0800)
committerDave Jones <davej@redhat.com>
Wed, 18 Jan 2006 21:53:46 +0000 (13:53 -0800)
Make the cpufreq code play nicely with the mutex debugging code: don't free a
held mutex.

Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Dave Jones <davej@redhat.com>
drivers/cpufreq/cpufreq.c

index 0675d9f02e345b462060b6cde651e6db1a0d4f4d..0a6c4c8642e72599cb0ffb609c1804a30040520f 100644 (file)
@@ -612,6 +612,7 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
        ret = cpufreq_driver->init(policy);
        if (ret) {
                dprintk("initialization failed\n");
+               mutex_unlock(&policy->lock);
                goto err_out;
        }
 
@@ -623,9 +624,10 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
        strlcpy(policy->kobj.name, "cpufreq", KOBJ_NAME_LEN);
 
        ret = kobject_register(&policy->kobj);
-       if (ret)
+       if (ret) {
+               mutex_unlock(&policy->lock);
                goto err_out_driver_exit;
-
+       }
        /* set up files for this cpu device */
        drv_attr = cpufreq_driver->attr;
        while ((drv_attr) && (*drv_attr)) {