minor code cleanups

git-svn-id: http://svn.opengroupware.org/SOPE/trunk@471 e4a50df8-12e2-0310-a44c-efbce7f8a7e3

diff --git a/sope-appserver/NGXmlRpc/ChangeLog b/sope-appserver/NGXmlRpc/ChangeLog
index d9374857add1317af63c1c4ac34f0d2dcd1bf266..510ab1f9d61dca80409f71bfa0e36b771248a429 100644 (file)
--- a/sope-appserver/NGXmlRpc/ChangeLog
+++ b/sope-appserver/NGXmlRpc/ChangeLog
@@ -1,3 +1,7 @@
+2005-01-02  Helge Hess  <helge.hess@opengroupware.org>
+
+       * WODirectAction+XmlRpc.m: minor code cleanups (v4.5.9)
+
 2004-11-11  Marcus Mueller  <znek@mulle-kybernetik.com>
 
        * NGXmlRpc.xcode: fixed a subtle bug that prevent Xcode from being

diff --git a/sope-appserver/NGXmlRpc/Version b/sope-appserver/NGXmlRpc/Version
index 46a90fece8d9225fe5e08bb0a71cc5146b9dcdf2..f725507183992c451c63ba6d27aef6b943c23b07 100644 (file)
--- a/sope-appserver/NGXmlRpc/Version
+++ b/sope-appserver/NGXmlRpc/Version
@@ -1,3 +1,3 @@
 # version file
 
-SUBMINOR_VERSION:=8
+SUBMINOR_VERSION:=9

diff --git a/sope-appserver/NGXmlRpc/WODirectAction+XmlRpc.m b/sope-appserver/NGXmlRpc/WODirectAction+XmlRpc.m
index b1fecd1ed5227ca174872efcacdc3d0a2c6c121e..83ff3bdb767bb7fdfb8204f655a4e714f8ffc23f 100644 (file)
--- a/sope-appserver/NGXmlRpc/WODirectAction+XmlRpc.m
+++ b/sope-appserver/NGXmlRpc/WODirectAction+XmlRpc.m
@@ -1,7 +1,7 @@
 /*
-  Copyright (C) 2000-2003 SKYRIX Software AG
+  Copyright (C) 2000-2004 SKYRIX Software AG
 
-  This file is part of OGo
+  This file is part of OpenGroupware.org.
 
   OGo is free software; you can redistribute it and/or modify it under
   the terms of the GNU Lesser General Public License as published by the
@@ -18,7 +18,6 @@
   Free Software Foundation, 59 Temple Place - Suite 330, Boston, MA
   02111-1307, USA.
 */
-// $Id$
 
 #include "WODirectAction+XmlRpc.h"
 #include <NGXmlRpc/NSObject+Reflection.h>
@@ -32,10 +31,12 @@
 static int CoreOnException = -1;
 
 - (NSString *)xmlrpcComponentNamespacePrefix {
+  // TODO: should be deprecated
+  NSUserDefaults *ud;
   NSString *np;
   
-  np = [[NSUserDefaults standardUserDefaults]
-                        stringForKey:@"SxDefaultNamespacePrefix"];
+  ud = [NSUserDefaults standardUserDefaults];
+  np = [ud stringForKey:@"SxDefaultNamespacePrefix"];
   if ([np length] > 0)
     return np;
 
@@ -75,6 +76,7 @@ static int CoreOnException = -1;
   return @"com.skyrix";
 }
 - (NSString *)xmlrpcComponentName {
+  // TODO: should be deprecated
   NSString *s;
 
   s = NSStringFromClass([self class]);
@@ -85,6 +87,7 @@ static int CoreOnException = -1;
 }
 
 - (NSString *)xmlrpcComponentNamespace {
+  // TODO: should be deprecated
   NSString *ns, *n;
   
   ns = [self xmlrpcComponentNamespacePrefix];
@@ -259,14 +262,16 @@ static int CoreOnException = -1;
   cnt = (cnt > (int)[_params count]) ? (int)[_params count] : cnt;
   
   for (i = 0; i < cnt; i++) {
-    id param = [_params objectAtIndex:i];
+    id param;
+    
+    param = [_params objectAtIndex:i];
     [invo setArgument:&param atIndex:(i + 2)];
   }
   // TODO(hh): should fill the remaining args when less params available ?
   
   [invo invoke];
   [invo getReturnValue:&result];
-
+  
   return result;
 }
 

diff --git a/sope-mime/NGMime/NGMimeRFC822DateHeaderFieldParser.m b/sope-mime/NGMime/NGMimeRFC822DateHeaderFieldParser.m
index 291a7269f31636b364cbfbcf600fd21ef9772a56..47c2ec2eab3a649b2ecb46e3e4587bc1fc5d6bd3 100644 (file)
--- a/sope-mime/NGMime/NGMimeRFC822DateHeaderFieldParser.m
+++ b/sope-mime/NGMime/NGMimeRFC822DateHeaderFieldParser.m
@@ -451,6 +451,7 @@ static NSTimeZone *parseTimeZone(unsigned char *s, unsigned int len) {
   return date;
   
  failed:
+  // TODO: 'Sun, May 18 2003 14:20:55 -0700' - why does this fail?
   [self logWithFormat:@"WARNING: failed to parse RFC822 date field: '%@'",
          _data];
   return nil;