]> err.no Git - linux-2.6/commitdiff
ieee1394: Remove superfluous calls to kobject_set_name().
authorRobert P. J. Day <rpjday@crashcourse.ca>
Thu, 27 Mar 2008 14:48:37 +0000 (10:48 -0400)
committerStefan Richter <stefanr@s5r6.in-berlin.de>
Fri, 18 Apr 2008 15:55:31 +0000 (17:55 +0200)
Unless you're adding a kobject to the sysfs hierarchy, there is no
point setting its kobject name.

Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
drivers/ieee1394/dv1394.c
drivers/ieee1394/raw1394.c
drivers/ieee1394/video1394.c

index 8c72f360f2d54742993f81184c0fbe3e3f8279c2..6228fadacd388d7ffd014548796dec4263cfe454 100644 (file)
@@ -2567,7 +2567,6 @@ static int __init dv1394_init_module(void)
 
        cdev_init(&dv1394_cdev, &dv1394_fops);
        dv1394_cdev.owner = THIS_MODULE;
-       kobject_set_name(&dv1394_cdev.kobj, "dv1394");
        ret = cdev_add(&dv1394_cdev, IEEE1394_DV1394_DEV, 16);
        if (ret) {
                printk(KERN_ERR "dv1394: unable to register character device\n");
index 3634785d3b4bbacbb31813b399a1dc1e8fefd958..04e96ba56e090af3cd4ff6ab44e5b1fb147d2fd1 100644 (file)
@@ -3003,7 +3003,6 @@ static int __init init_raw1394(void)
 
        cdev_init(&raw1394_cdev, &raw1394_fops);
        raw1394_cdev.owner = THIS_MODULE;
-       kobject_set_name(&raw1394_cdev.kobj, RAW1394_DEVICE_NAME);
        ret = cdev_add(&raw1394_cdev, IEEE1394_RAW1394_DEV, 1);
        if (ret) {
                HPSB_ERR("raw1394 failed to register minor device block");
index cc240b2e72d97f8af92fe6121b8f9c112831c30e..e03024eeeac135fac1da8b5422b7b84e3a4d16d3 100644 (file)
@@ -1503,7 +1503,6 @@ static int __init video1394_init_module (void)
 
        cdev_init(&video1394_cdev, &video1394_fops);
        video1394_cdev.owner = THIS_MODULE;
-       kobject_set_name(&video1394_cdev.kobj, VIDEO1394_DRIVER_NAME);
        ret = cdev_add(&video1394_cdev, IEEE1394_VIDEO1394_DEV, 16);
        if (ret) {
                PRINT_G(KERN_ERR, "video1394: unable to get minor device block");