]> err.no Git - linux-2.6/commitdiff
ide-cris: don't override ide_register_hw() result
authorBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Tue, 27 Nov 2007 20:35:55 +0000 (21:35 +0100)
committerBartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Tue, 27 Nov 2007 20:35:55 +0000 (21:35 +0100)
* Don't override ide_register_hw() result and check if there is a hwif
  available to use.

* MAX_HWIFS is user configurable nowadays so replace it by hard-coded value.

* Remove the comment about ide_hwifs[].

Acked-by: Mikael Starvik <starvik@axis.com>
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
drivers/ide/cris/ide-cris.c

index 7f5bc2ee6c7e554d631ea6c0c1e8f42cc3a66940..476e0d65ed438f34375b155f0b80169f39a2b6fa 100644 (file)
@@ -773,15 +773,16 @@ init_e100_ide (void)
        /* the IDE control register is at ATA address 6, with CS1 active instead of CS0 */
        ide_offsets[IDE_CONTROL_OFFSET] = cris_ide_reg_addr(6, 1, 0);
 
-       /* first fill in some stuff in the ide_hwifs fields */
+       for (h = 0; h < 4; h++) {
+               ide_hwif_t *hwif = NULL;
 
-       for(h = 0; h < MAX_HWIFS; h++) {
-               ide_hwif_t *hwif = &ide_hwifs[h];
                ide_setup_ports(&hw, cris_ide_base_address(h),
                                ide_offsets,
                                0, 0, cris_ide_ack_intr,
                                ide_default_irq(0));
                ide_register_hw(&hw, NULL, 1, &hwif);
+               if (hwif == NULL)
+                       continue;
                hwif->mmio = 1;
                hwif->chipset = ide_etrax100;
                hwif->set_pio_mode = &cris_set_pio_mode;