]> err.no Git - linux-2.6/commitdiff
ath5k/phy.c: fix negative array index
authorLuis R. Rodriguez <mcgrof@winlab.rutgers.edu>
Mon, 4 Feb 2008 02:53:51 +0000 (21:53 -0500)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 29 Feb 2008 20:19:38 +0000 (15:19 -0500)
Author: Adrian Bunk <bunk@kernel.org>

This patch fixes a negative array index spotted by the Coverity checker.

Changes-licensed-under: ISC

Acked-by: Nick Kossifidis <mickflemm@gmail.com>
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Luis R. Rodriguez <mcgrof@winlab.rutgers.edu>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/ath5k/phy.c

index 248c0f545f249b0213d499f8629c231f23d230ad..405195ffb24d49f042f4cc30d1d06f2e56b91dc5 100644 (file)
@@ -1178,6 +1178,9 @@ static int ath5k_hw_rf5112_rfregs(struct ath5k_hw *ah,
                        (channel->center_freq >= 5260 ? 1 :
                            (channel->center_freq > 4000 ? 0 : -1)));
 
+               if (obdb == -1)
+                       return -EINVAL;
+
                if (!ath5k_hw_rfregs_op(rf, ah->ah_offset[6],
                                ee->ee_ob[ee_mode][obdb], 3, 279, 0, true))
                        return -EINVAL;