]> err.no Git - linux-2.6/commitdiff
rt2x00: Fix scheduling while atomic errors in usb drivers
authorIvo van Doorn <ivdoorn@gmail.com>
Sun, 10 Feb 2008 21:50:04 +0000 (22:50 +0100)
committerJohn W. Linville <linville@tuxdriver.com>
Fri, 29 Feb 2008 20:37:19 +0000 (15:37 -0500)
Call rt2x00_config_intf() outside of the spinlock context since
the call will sleep for USB drivers. By using the ieee80211_if_conf
values as arguments we make keep access tp rt2x00_intf thread safe
even without the lock.

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
drivers/net/wireless/rt2x00/rt2x00mac.c

index 8c24d3b36d289785487c760965a18ea472ae9e26..91b62ddbf9f040619e9a71c290b961c5400b0141 100644 (file)
@@ -334,10 +334,17 @@ int rt2x00mac_config_interface(struct ieee80211_hw *hw,
         */
        if (conf->type != IEEE80211_IF_TYPE_AP)
                memcpy(&intf->bssid, conf->bssid, ETH_ALEN);
-       rt2x00lib_config_intf(rt2x00dev, intf, conf->type, NULL, intf->bssid);
 
        spin_unlock(&intf->lock);
 
+       /*
+        * Call rt2x00_config_intf() outside of the spinlock context since
+        * the call will sleep for USB drivers. By using the ieee80211_if_conf
+        * values as arguments we make keep access to rt2x00_intf thread safe
+        * even without the lock.
+        */
+       rt2x00lib_config_intf(rt2x00dev, intf, conf->type, NULL, conf->bssid);
+
        /*
         * We only need to initialize the beacon when master mode is enabled.
         */