]> err.no Git - linux-2.6/commitdiff
USB: remove unnecessary tests in isp116x and sl811
authorAlan Stern <stern@rowland.harvard.edu>
Thu, 16 Aug 2007 20:17:49 +0000 (16:17 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 12 Oct 2007 21:55:16 +0000 (14:55 -0700)
This patch (as962) cleans up some code I forgot to remove earlier in
the isp116x and sl811 HCDs.  There is no longer any need to check for
unlink-during-submit; it can't happen since the endpoint queues are
now under the protection of the HCD-private spinlock.

Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
CC: David Brownell <david-b@pacbell.net>
CC: Olav Kongas <ok@artecdesign.ee>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/host/isp116x-hcd.c
drivers/usb/host/sl811-hcd.c

index d5027dc75a57b475cfe7d7177e829a3aaf3a8e36..f2b5d6281c5d6a163e5a7fdd36024aedb1a9807b 100644 (file)
@@ -815,12 +815,6 @@ static int isp116x_urb_enqueue(struct usb_hcd *hcd,
                }
        }
 
-       /* in case of unlink-during-submit */
-       if (urb->status != -EINPROGRESS) {
-               finish_request(isp116x, ep, urb);
-               ret = 0;
-               goto fail;
-       }
        urb->hcpriv = hep;
        start_atl_transfers(isp116x);
 
index 3d3a63d002c536e499c0aa25098413a2569b4b50..15a93f946afdf4d7bdd250f7291949ff4e216890 100644 (file)
@@ -957,17 +957,7 @@ static int sl811h_urb_enqueue(
                sofirq_on(sl811);
        }
 
-       /* in case of unlink-during-submit */
-       spin_lock(&urb->lock);
-       if (urb->status != -EINPROGRESS) {
-               spin_unlock(&urb->lock);
-               finish_request(sl811, ep, urb, 0);
-               retval = 0;
-               goto fail;
-       }
        urb->hcpriv = hep;
-       spin_unlock(&urb->lock);
-
        start_transfer(sl811);
        sl811_write(sl811, SL11H_IRQ_ENABLE, sl811->irq_enable);
 fail: