]> err.no Git - linux-2.6/commitdiff
drivers/net/irda/au1k_ir: fix obvious irq handler bugs
authorJeff Garzik <jeff@garzik.org>
Mon, 29 Oct 2007 09:18:12 +0000 (05:18 -0400)
committerJeff Garzik <jeff@garzik.org>
Mon, 29 Oct 2007 09:42:18 +0000 (05:42 -0400)
interrupt handlers return a return value these days.

Also, kill always-true test and unneeded void* cast.

Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
drivers/net/irda/au1k_ir.c

index 4dbdfaaf37bf4473003b198cec87f718bafcfcc5..a1e4508717c8743bfa8f8d15c77a1383318e8884 100644 (file)
@@ -627,19 +627,16 @@ static int au1k_irda_rx(struct net_device *dev)
 }
 
 
-void au1k_irda_interrupt(int irq, void *dev_id)
+static irqreturn_t au1k_irda_interrupt(int dummy, void *dev_id)
 {
-       struct net_device *dev = (struct net_device *) dev_id;
-
-       if (dev == NULL) {
-               printk(KERN_ERR "%s: isr: null dev ptr\n", dev->name);
-               return;
-       }
+       struct net_device *dev = dev_id;
 
        writel(0, IR_INT_CLEAR); /* ack irda interrupts */
 
        au1k_irda_rx(dev);
        au1k_tx_ack(dev);
+
+       return IRQ_HANDLED;
 }