]> err.no Git - linux-2.6/commitdiff
USB iowarrior.c: fix check-after-use
authorAdrian Bunk <bunk@kernel.org>
Thu, 18 Oct 2007 10:52:50 +0000 (12:52 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 25 Oct 2007 19:18:43 +0000 (12:18 -0700)
The Coverity checker spotted that we have already oops'ed if "dev"
was NULL.

Since "dev" being NULL doesn't seem to be possible here this patch
removes the NULL check.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/misc/iowarrior.c

index d372fbc4effbb0a44c31213142c92f720a13bea3..c86c132d8aaee9878030ecfbfacdeaac8d0ba9dc 100644 (file)
@@ -351,7 +351,7 @@ static ssize_t iowarrior_write(struct file *file,
 
        mutex_lock(&dev->mutex);
        /* verify that the device wasn't unplugged */
-       if (dev == NULL || !dev->present) {
+       if (!dev->present) {
                retval = -ENODEV;
                goto exit;
        }