]> err.no Git - linux-2.6/commitdiff
[TIPC]: Add argument validation for shutdown()
authorAllan Stephens <allan.stephens@windriver.com>
Thu, 6 Mar 2008 23:05:38 +0000 (15:05 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 6 Mar 2008 23:05:38 +0000 (15:05 -0800)
This patch validates that the "how" argument to shutdown()
is SHUT_RDWR, since this is the only form that TIPC supports.

Signed-off-by: Allan Stephens <allan.stephens@windriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/socket.c

index 9ae8e9f74028f23b86841b57e16318d445b84e07..3220d5cb5b5d3d14d9192fe2d6d2443565fe64fe 100644 (file)
@@ -1419,7 +1419,7 @@ exit:
 /**
  * shutdown - shutdown socket connection
  * @sock: socket structure
- * @how: direction to close (unused; always treated as read + write)
+ * @how: direction to close (must be SHUT_RDWR)
  *
  * Terminates connection (if necessary), then purges socket's receive queue.
  *
@@ -1432,7 +1432,8 @@ static int shutdown(struct socket *sock, int how)
        struct sk_buff *buf;
        int res;
 
-       /* Could return -EINVAL for an invalid "how", but why bother? */
+       if (how != SHUT_RDWR)
+               return -EINVAL;
 
        if (mutex_lock_interruptible(&tsock->lock))
                return -ERESTARTSYS;