]> err.no Git - linux-2.6/commitdiff
[PATCH] bonding: cleanup comment for mode 1 IGMP xmit hack
authorJohn W. Linville <linville@tuxdriver.com>
Wed, 19 Oct 2005 01:30:58 +0000 (21:30 -0400)
committerJeff Garzik <jgarzik@pobox.com>
Wed, 19 Oct 2005 02:27:13 +0000 (22:27 -0400)
Expand comment explaining MAC address selection for replicated IGMP
frames transmitted in bonding mode 1 (active-backup).  Also, a small
whitespace cleanup.

Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
drivers/net/bonding/bond_main.c

index 58c4e36f87d79990a797cc8fd7949881ce7dfb3a..8032126fd5891845ecee2ba19de06a28f312ddbb 100644 (file)
@@ -4242,8 +4242,8 @@ out:
 }
 
 static void bond_activebackup_xmit_copy(struct sk_buff *skb,
-                                         struct bonding *bond,
-                                         struct slave *slave)
+                                        struct bonding *bond,
+                                        struct slave *slave)
 {
        struct sk_buff *skb2 = skb_copy(skb, GFP_ATOMIC);
        struct ethhdr *eth_data;
@@ -4259,7 +4259,11 @@ static void bond_activebackup_xmit_copy(struct sk_buff *skb,
        skb2->mac.raw = (unsigned char *)skb2->data;
        eth_data = eth_hdr(skb2);
 
-       /* Pick an appropriate source MAC address */
+       /* Pick an appropriate source MAC address
+        *      -- use slave's perm MAC addr, unless used by bond
+        *      -- otherwise, borrow active slave's perm MAC addr
+        *         since that will not be used
+        */
        hwaddr = slave->perm_hwaddr;
        if (!memcmp(eth_data->h_source, hwaddr, ETH_ALEN))
                hwaddr = bond->curr_active_slave->perm_hwaddr;