]> err.no Git - linux-2.6/commitdiff
[CIFS] cleanup sparse and compile errors in previous fix
authorSteve French <sfrench@us.ibm.com>
Thu, 6 Oct 2005 02:32:49 +0000 (19:32 -0700)
committerSteve French <sfrench@us.ibm.com>
Thu, 6 Oct 2005 02:32:49 +0000 (19:32 -0700)
Signed-off-by: Steve French (sfrench@us.ibm.com)
fs/cifs/file.c
fs/cifs/inode.c

index 0f66ae5b694ba7ed451afacd8abbfe4dd51a8fde..39b23f4fa6c323232c162b94a2b92e3b6a399993 100644 (file)
@@ -907,9 +907,10 @@ static ssize_t cifs_write(struct file *file, const char *write_data,
        return total_written;
 }
 
-static struct cifsFileInfo *find_writable_file(struct cifsInodeInfo *cifs_inode)
+struct cifsFileInfo *find_writable_file(struct cifsInodeInfo *cifs_inode)
 {
        struct cifsFileInfo *open_file;
+       int rc;
 
        read_lock(&GlobalSMBSeslock);
        list_for_each_entry(open_file, &cifs_inode->openFileList, flist) {
@@ -920,7 +921,7 @@ static struct cifsFileInfo *find_writable_file(struct cifsInodeInfo *cifs_inode)
                     (open_file->pfile->f_flags & O_WRONLY))) {
                        read_unlock(&GlobalSMBSeslock);
                        if(open_file->invalidHandle) {
-                               rc = cifs_reopen_file(cifs_inode->vfs_inode, 
+                               rc = cifs_reopen_file(&cifs_inode->vfs_inode, 
                                                      open_file->pfile, FALSE);
                                /* if it fails, try another handle - might be */
                                /* dangerous to hold up writepages with retry */
index 49efdefcff7c65ed527e045ffa6beba63c97626b..ff4d1cc7c2484b1ce4be12054c05398d77c9b531 100644 (file)
@@ -962,7 +962,6 @@ int cifs_setattr(struct dentry *direntry, struct iattr *attrs)
        struct cifsTconInfo *pTcon;
        char *full_path = NULL;
        int rc = -EACCES;
-       int found = FALSE;
        struct cifsFileInfo *open_file = NULL;
        FILE_BASIC_INFO time_buf;
        int set_time = FALSE;
@@ -970,7 +969,6 @@ int cifs_setattr(struct dentry *direntry, struct iattr *attrs)
        __u64 uid = 0xFFFFFFFFFFFFFFFFULL;
        __u64 gid = 0xFFFFFFFFFFFFFFFFULL;
        struct cifsInodeInfo *cifsInode;
-       struct list_head *tmp;
 
        xid = GetXid();