]> err.no Git - linux-2.6/commitdiff
V4L/DVB (4991): Cafe_ccic.c: fix NULL dereference
authorAdrian Bunk <bunk@stusta.de>
Wed, 20 Dec 2006 12:34:32 +0000 (09:34 -0300)
committerMauro Carvalho Chehab <mchehab@infradead.org>
Wed, 27 Dec 2006 16:19:56 +0000 (14:19 -0200)
We shouldn't dereference "cam" when we already know it's NULL.
Spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
drivers/media/video/cafe_ccic.c

index e347c7ebc98415b6c8dc0d0d3f0492d0440740a4..3083c8075d13af459e033af0cbe6544340b08358 100644 (file)
@@ -2166,7 +2166,7 @@ static void cafe_pci_remove(struct pci_dev *pdev)
        struct cafe_camera *cam = cafe_find_by_pdev(pdev);
 
        if (cam == NULL) {
-               cam_warn(cam, "pci_remove on unknown pdev %p\n", pdev);
+               printk(KERN_WARNING "pci_remove on unknown pdev %p\n", pdev);
                return;
        }
        mutex_lock(&cam->s_mutex);