]> err.no Git - linux-2.6/commitdiff
[PATCH] cpufreq-nforce2.c fix u32<0 test
authorGabriel A. Devenyi <ace@staticwave.ca>
Thu, 1 Dec 2005 09:09:22 +0000 (01:09 -0800)
committerDave Jones <davej@redhat.com>
Thu, 1 Dec 2005 09:23:24 +0000 (01:23 -0800)
Thanks to LinuxICC (http://linuxicc.sf.net), a comparison of a u32 less
than 0 was found, this patch changes the variable to a signed int so that
comparison is meaningful.

Signed-off-by: Gabriel A. Devenyi <ace@staticwave.ca>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Dave Jones <davej@redhat.com>
arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c

index 04a405345203424388d15b050310642b723f00aa..2b62dee35c6c83299105b46ffc5e00b8969b3c5d 100644 (file)
@@ -177,9 +177,10 @@ static unsigned int nforce2_fsb_read(int bootfsb)
  */
 static int nforce2_set_fsb(unsigned int fsb)
 {
-       u32 pll, temp = 0;
+       u32 temp = 0;
        unsigned int tfsb;
        int diff;
+       int pll = 0;
 
        if ((fsb > max_fsb) || (fsb < NFORCE2_MIN_FSB)) {
                printk(KERN_ERR "cpufreq: FSB %d is out of range!\n", fsb);