]> err.no Git - linux-2.6/commitdiff
net/phy/mdio_bus.c: fix a check-after-use
authorAdrian Bunk <bunk@kernel.org>
Wed, 20 Feb 2008 00:13:53 +0000 (02:13 +0200)
committerJeff Garzik <jeff@garzik.org>
Sun, 24 Feb 2008 04:57:50 +0000 (23:57 -0500)
This patch fixes a check-after-use spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/phy/mdio_bus.c

index 6e9f619c491f74837a7f356943683094169e28bf..963630c65ca940d9dfc59ed57370c54dbfed7847 100644 (file)
@@ -49,13 +49,13 @@ int mdiobus_register(struct mii_bus *bus)
        int i;
        int err = 0;
 
-       mutex_init(&bus->mdio_lock);
-
        if (NULL == bus || NULL == bus->name ||
                        NULL == bus->read ||
                        NULL == bus->write)
                return -EINVAL;
 
+       mutex_init(&bus->mdio_lock);
+
        if (bus->reset)
                bus->reset(bus);