]> err.no Git - linux-2.6/commitdiff
[RFKILL]: Fix check for correct rfkill allocation
authorIvo van Doorn <IvDoorn@gmail.com>
Sat, 19 May 2007 19:24:39 +0000 (12:24 -0700)
committerDavid S. Miller <davem@davemloft.net>
Sat, 19 May 2007 19:24:39 +0000 (12:24 -0700)
coverity has spotted a bug in rfkill.c (bug id #1627),
in rfkill_allocate() NULL was returns if the kzalloc() works,
and deref the NULL pointer if it fails,

Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/rfkill/rfkill.c

index a973603e388028925b73c1c5b893f3a279bf6c29..f3986d498b4088622084a121fa0bcc73b07f228e 100644 (file)
@@ -296,7 +296,7 @@ struct rfkill *rfkill_allocate(struct device *parent, enum rfkill_type type)
        struct device *dev;
 
        rfkill = kzalloc(sizeof(struct rfkill), GFP_KERNEL);
-       if (rfkill)
+       if (!rfkill)
                return NULL;
 
        mutex_init(&rfkill->mutex);