]> err.no Git - linux-2.6/commitdiff
[IA64] fix bug in ia64 __mutex_fastpath_trylock
authorChen, Kenneth W <kenneth.w.chen@intel.com>
Sat, 8 Apr 2006 00:12:54 +0000 (17:12 -0700)
committerTony Luck <tony.luck@intel.com>
Sat, 8 Apr 2006 05:39:49 +0000 (22:39 -0700)
The parenthesis around "likely" used in ia64 __mutex_fastpath_trylock
is incorrect, and it leads to broken mutex_trylock.  Here is the
patch that fixed the bug.  I removed the likely altogether because
there is no branch and gcc does a reasonable job at predicating the
return value.

Signed-off-by: Ken Chen <kenneth.w.chen@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
include/asm-ia64/mutex.h

index 5a3224f6af380aaa89aeb71f081ff6909304d9de..bed73a643a56e3c0169a4fd43b705fcba491f5c8 100644 (file)
@@ -84,7 +84,7 @@ __mutex_fastpath_unlock(atomic_t *count, void (*fail_fn)(atomic_t *))
 static inline int
 __mutex_fastpath_trylock(atomic_t *count, int (*fail_fn)(atomic_t *))
 {
-       if (likely(cmpxchg_acq(count, 1, 0)) == 1)
+       if (cmpxchg_acq(count, 1, 0) == 1)
                return 1;
        return 0;
 }