]> err.no Git - linux-2.6/commitdiff
[SCSI] zfcp: avoid if (whatever) ; constructs.
authorHeiko Carstens <heiko.carstens@de.ibm.com>
Tue, 28 Aug 2007 07:30:42 +0000 (09:30 +0200)
committerJames Bottomley <jejb@mulgrave.localdomain>
Fri, 12 Oct 2007 18:46:18 +0000 (14:46 -0400)
Avoid "if (whatever) ;" constructs since they seem to confuse people,
even if there is a comment.

Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Signed-off-by: Swen Schillig <swen@vnet.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
drivers/s390/scsi/zfcp_erp.c

index d8cd75ce2d9a37c1675d3c29af6fc9884dc00b66..40fa056e2575abcaae08cc25bbc343437d150360 100644 (file)
@@ -1687,8 +1687,8 @@ zfcp_erp_strategy_followup_actions(int action,
                break;
 
        case ZFCP_ERP_ACTION_REOPEN_UNIT:
-               if (status == ZFCP_ERP_SUCCEEDED) ;     /* no further action */
-               else
+               /* Nothing to do if status == ZFCP_ERP_SUCCEEDED */
+               if (status != ZFCP_ERP_SUCCEEDED)
                        zfcp_erp_port_reopen_internal(unit->port, 0);
                break;
        }